Skip to content

Inline charts.css #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Sleavely wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Inline charts.css #18

Sleavely wants to merge 4 commits into from

Conversation

@Sleavely
Copy link
Collaborator

@Sleavely Sleavely commented Mar 2, 2024

This PR includes two changes:

  • Rather than loading charts.css from unpkg.com we install it as a dependency from npm and import it as if it was an exported string from that module. We then place the string in a <style> tag appended to <head>
  • The fetchMe method will now reuse the same network request no matter how many times it is called.

Sleavely
Sleavely commented Mar 2, 2024
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Furiiku Furiiku Furiiku approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Sleavely @Furiiku