pdfx: fix error if rawDocumentProgress is NaN #602
+6
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using pdfx 2.9.2, and also when using the latest changes on main.
I'm seeing the PDF widget render as a white block on iOS, or very occasionally a red Flutter error:
It seems to be fine if using Axis.vertical but not when using horizontal scrolling:
The error in my logs is:
Which through debugging is caused by line 298 of pdf_view_pinch.dart inside _determinePagesToShow():
In my case, the rawDocumentProgress calculation ended up being
(503.15789473684214 - 503.15789473684214) / (503.15789473684214 - 503.15789473684214)= 0/0 which results in a NaN in Flutter.This PR adds a check to set the progress to 0 if rawDocumentProgress is NaN.
It seems to work OK, but I have no idea if this will have any negative effects elsewhere
Thanks