Update vault-install.sh #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue with new hashi structure with new extension type
|
Do you have a link to any indication of this in the Hashi Docs that we could reference? |
Author
|
The only way that you can see this by going to the down load site and looking at the various files; naming that they have. https://releases.hashicorp.com/vault/ code looks for this first instance of +ent. It may have one of the extensions part in it the line or not. Didnt think of this before. Instead of removing the extension part. could do a cut on "+" and take the first part. |
Better way to get the current version
Author
|
Updated to look for +ent and use cut to isolate the version number. cleaner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix issue with new hashi structure with new extension type
What image or gif best represents this PR?
Why is this needed?
Hashi added an extension to their releases
How does it work?
Please explain how this was tested
Screenshots (optional)
Documentation
Anything Else?