Skip to content

Update app.js #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alecreez6 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update app.js #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,12 @@ const { creditAccount, debitAccount } = require('./helpers/transactions');

dotenv.config();


/**
* @param {string} username username of the user
* @param {string} password password of the user
*/

async function createUser(username, password) {
const schema = joi.object({
username: joi.string().required(),
Expand All @@ -26,17 +28,21 @@ async function createUser(username, password) {
const t = await models.sequelize.transaction();

try {

const existingUser = await models.users.findOne({ where: { username } }, { transaction: t });
if (existingUser) {
return {
success: false,
error: 'Account already exists',

};

}
const user = await models.users.create({
username,
password: bcrypt.hashSync(password, bcrypt.genSaltSync(10)),
}, {
},
{
transaction: t,
});

Expand All @@ -52,9 +58,11 @@ async function createUser(username, password) {
success: true,
message: 'User account created',
};

} catch (error) {
await t.rollback();
return {
return
{
success: false,
error: 'Internal server error',
};
Expand All @@ -69,7 +77,8 @@ async function deposit(account_id, amount) {
const schema = joi.object({
account_id: joi.number().required(),
amount: joi.number().min(1).required(),
});
}
);
const validation = schema.validate({ account_id, amount });
if (validation.error) {
return {
Expand All @@ -84,7 +93,8 @@ async function deposit(account_id, amount) {
amount,
purpose: 'deposit',
t,
});
}
);

if (!creditResult.success) {
await t.rollback();
Expand Down Expand Up @@ -113,7 +123,8 @@ async function withdraw(account_id, amount) {
const schema = joi.object({
account_id: joi.number().required(),
amount: joi.number().min(1).required(),
});
}
);
const validation = schema.validate({ account_id, amount });
if (validation.error) {
return {
Expand Down