feat: auto-register simulator code app when none exists#9
Merged
Conversation
Commands that need a code app (approve, open, copy, save) now automatically register one via the MitID test simulator API if the identity has no active code app. Opt out with --no-register. Also filters for ACTIVE authenticators when resolving, so revoked code apps are no longer picked up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
approve,open,copy,save) now auto-register one via the MitID test simulator API (POST /authenticators/code-app/simulator) when the identity has no active code app--no-registerflag to opt out of auto-registrationACTIVEauthenticators when resolving — revoked code apps are no longer picked upinfo,json) are unchanged and just report what existsregisterCodeAppfor library consumers