feat: JSON output from login with token capture#10
Merged
Conversation
login command now outputs structured JSON to stdout with cookies, response body (when JSON), finalUrl, and provider. Progress messages go to stderr so piping works cleanly (e.g. | jq '.body.access_token'). Services returning tokens as JSON body instead of cookies are now captured in the output. Closes #8
Body is now always present — parsed as JSON when possible, raw string otherwise. No data is lost regardless of response content type.
- Remove unused private userId field in MitIDClient - Update README to reflect body is always present
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #8
mitid loginnow outputs structured JSON to stdout withcookies,body(when JSON),finalUrl, andprovidermitid login user url | jq '.body.access_token'access_token,refresh_token) are now captured in thebodyfieldpbcopy/xclipinsteadjqexamplesExample output
{ "provider": "Criipto", "finalUrl": "https://service.example.com/callback", "cookies": { "session": "abc123" }, "body": { "access_token": "eyJ...", "refresh_token": "..." } }Breaking changes
mitid loginstdout is now JSON (was human-readable text with truncated cookies)LoginResulttype now includesbody: string