feat: docked toolbars in window, overlay toolbars in fullscreen#425
Open
RobertMueller2 wants to merge 2 commits intoSatty-org:mainfrom
Open
feat: docked toolbars in window, overlay toolbars in fullscreen#425RobertMueller2 wants to merge 2 commits intoSatty-org:mainfrom
RobertMueller2 wants to merge 2 commits intoSatty-org:mainfrom
Conversation
Closes: Satty-org#213 Closes: Satty-org#396 Adwaita provides [theme variables for headerbars](https://gnome.pages.gitlab.gnome.org/libadwaita/doc/1-latest/css-variables.html#header-bar-colors), use those instead of hardcoded values. Also, move default css into its own file (Satty-org#213). The current implementation adds the overrides.css file to the same provider. This clears all default settings. This commit addresses this by adding an additional provider if the overrides file is present. Lastly, mention override in README.
Related to: Satty-org#49 Not closing because there's some followup GUI revamp discussion in there. Note that this PR includes PR Satty-org#398. I try to avoid this, but it really makes no sense otherwise in this particular case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #49
Not closing because there's some followup GUI revamp discussion in there.Note that this PR includes PR #398. I try to avoid this, but it really makes no sense otherwise in this particular case.
This PR adds an outer box which the toolbars reside in. When switching to fullscreen, toolbars are put to the overlay, when going back to window, the toolbars get docked into the outer box again.
I should probably attach a video, but I'm too lazy now.the CSS in the PR is better than in the recording, the toolbar and box should get the same bg colour by default. This is just from my testing here.
output-fullscreen.mp4