fix!: use OUT_DIR only for cargo publish compatibility#409
Open
RobertMueller2 wants to merge 1 commit intoSatty-org:mainfrom
Open
fix!: use OUT_DIR only for cargo publish compatibility#409RobertMueller2 wants to merge 1 commit intoSatty-org:mainfrom
RobertMueller2 wants to merge 1 commit intoSatty-org:mainfrom
Conversation
RobertMueller2
force-pushed
the
fix_395b
branch
from
ef442e0 to
bd1bd70
Compare
Introduces a feature ci-release which can be used to generate completions to "completions" dir. Otherwise, in cargo publish scenario, have clap_complete generate these to OUT_DIR. Otherwise cargp publish complains about stuff generated to outside of OUT_DIR. This needs a modification of the workflow to use this new feature, otherwise packing the completions becomes considerably more difficult. While we're at it, install completions via make install as well. This works well if /usr/local is used as a prefix but is not perfect yet for user home installations.
RobertMueller2
force-pushed
the
fix_395b
branch
from
bd1bd70 to
53e969e
Compare
RobertMueller2
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #395
Introduces a feature ci-release which can be used to generate completions to "completions" dir.
Otherwise, in cargo publish scenario, have clap_complete generate these to OUT_DIR. Otherwise cargo publish complains about stuff generated to outside of OUT_DIR.
This needs a modification of the release/flatpak workflows to use this new feature, otherwise packing the completions from the OUT_DIR would become considerably more difficult.
While we're at it, install completions via
make installas well. This works well if /usr/local is used as a prefix but is not perfect yet for user home installations.EDIT: For the release notes: This may need a note for package maintainers, if they're not using the ci-release feature, they may have trouble finding the completions in the artifact directory.