Skip to content

⚡ Bolt: optimize list deduplication #4831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
SatoryKono wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −8
Draft

⚡ Bolt: optimize list deduplication #4831

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions src/bioetl/infrastructure/adapters/common/deduplication.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,9 @@

def deduplicate_preserving_order(values: Iterable[str]) -> list[str]:
"""Return unique values while preserving the original order."""
unique_values: list[str] = []
seen_values: set[str] = set()
for value in values:
if value in seen_values:
continue
seen_values.add(value)
unique_values.append(value)
return unique_values
# Optimization: dict.fromkeys leverages C-level iteration and insertion order
# preservation to deduplicate faster than a pure-Python seen-set loop.
return list(dict.fromkeys(values))


def iter_deduplicated_records(
Expand Down
Loading