Skip to content

⚡ Bolt: optimize config list deduplication #4742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
SatoryKono wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

⚡ Bolt: optimize config list deduplication #4742

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions src/bioetl/infrastructure/config_merge.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,9 @@ def _default_concat_list_merger(
if all(isinstance(item, str) for item in base) and all(
isinstance(item, str) for item in override
):
seen: set[str] = set()
merged: list[Any] = [] # Any: YAML config values are heterogeneous
for item in base + override:
item_str = str(item)
if item_str not in seen:
seen.add(item_str)
merged.append(item)
return merged
# OPTIMIZATION: dict.fromkeys() leverages fast C-level iteration and
# insertion-order preservation, outperforming pure-Python seen=set() loops
return list(dict.fromkeys(base + override))

return [*base, *override]

Expand Down
Loading