Skip to content

🧪 Add custom marker and empty input tests for split_filter_ids_for_fallback #4734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
SatoryKono wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

🧪 Add custom marker and empty input tests for split_filter_ids_for_fallback #4734

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ebe2d5
🧪 Add tests for split_filter_ids_for_fallback
google-labs-jules[bot] May 27, 2026
f0899ac
🧪 Add custom marker and empty input tests for `split_filter_ids_for_f…
google-labs-jules[bot] May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions tests/unit/infrastructure/adapters/common/test_fetch_retry_policy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,3 +314,18 @@ async def primary_records() -> AsyncIterator[dict[str, object]]:

assert [str(item["id"]) for item in results] == ["p1"]
assert fallback.calls == []


def test_split_filter_ids_for_fallback_custom_marker() -> None:
primary, title_only = split_filter_ids_for_fallback(
["10.1/a", "__custom_marker_0__", "10.2/b"],
title_only_marker_prefix="__custom_marker_",
)
assert primary == ["10.1/a", "10.2/b"]
assert title_only == ["__custom_marker_0__"]


def test_split_filter_ids_for_fallback_empty_input() -> None:
primary, title_only = split_filter_ids_for_fallback([])
assert primary == []
assert title_only == []
Loading