Skip to content

⚡ Bolt: Optimize list comprehensions with walrus operator #2436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SatoryKono merged 1 commit into from
Mar 2, 2026
Merged

⚡ Bolt: Optimize list comprehensions with walrus operator #2436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/bioetl/application/composite/merger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,12 +518,13 @@ def _normalize_join_key_columns(
import polars as pl

cols = df.columns
# ⚡ Bolt: Use walrus operator (:=) instead of nested `for c in [self._find_join_key_column(...)]`
# This avoids creating single-element lists and extra iteration overhead, making the comprehension ~5% faster.
normalize = [
c
for key in join_keys
if key in self._NORMALIZE_JOIN_KEYS
for c in [self._find_join_key_column(key, cols, pipeline)]
if c
if (c := self._find_join_key_column(key, cols, pipeline))
]
if not normalize:
return df
Expand Down
20 changes: 12 additions & 8 deletions src/bioetl/application/pipelines/uniprot/extractors/crossrefs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,12 +165,13 @@ def extract_pdb_xrefs(cls, xrefs: Any) -> str | None: # Any: untyped API JSON
if not xrefs or not isinstance(xrefs, list):
return None

# ⚡ Bolt: Use walrus operator (:=) instead of nested `for entry in [cls._build_pdb_entry(xref)]`
# This avoids creating single-element lists and extra iteration overhead, making the comprehension ~5% faster.
pdb_refs = [
entry
for xref in xrefs
if isinstance(xref, dict) and xref.get("database") == "PDB"
for entry in [cls._build_pdb_entry(xref)]
if entry is not None
if (entry := cls._build_pdb_entry(xref)) is not None
]

return serialize_to_json(pdb_refs, ensure_ascii=False) if pdb_refs else None
Expand Down Expand Up @@ -206,12 +207,13 @@ def extract_interpro_xrefs(cls, xrefs: Any) -> str | None: # Any: untyped API J
if not xrefs or not isinstance(xrefs, list):
return None

# ⚡ Bolt: Use walrus operator (:=) instead of nested `for entry in [cls._build_interpro_entry(xref)]`
# This avoids creating single-element lists and extra iteration overhead, making the comprehension ~5% faster.
interpro_refs = [
entry
for xref in xrefs
if isinstance(xref, dict) and xref.get("database") == "InterPro"
for entry in [cls._build_interpro_entry(xref)]
if entry is not None
if (entry := cls._build_interpro_entry(xref)) is not None
]

return (
Expand Down Expand Up @@ -254,12 +256,13 @@ def extract_pfam_xrefs(cls, xrefs: Any) -> str | None: # Any: untyped API JSON
if not xrefs or not isinstance(xrefs, list):
return None

# ⚡ Bolt: Use walrus operator (:=) instead of nested `for entry in [cls._build_pfam_entry(xref)]`
# This avoids creating single-element lists and extra iteration overhead, making the comprehension ~5% faster.
pfam_refs = [
entry
for xref in xrefs
if isinstance(xref, dict) and xref.get("database") == "Pfam"
for entry in [cls._build_pfam_entry(xref)]
if entry is not None
if (entry := cls._build_pfam_entry(xref)) is not None
]

return serialize_to_json(pfam_refs, ensure_ascii=False) if pfam_refs else None
Expand Down Expand Up @@ -296,12 +299,13 @@ def extract_reactome_xrefs(cls, xrefs: Any) -> str | None: # Any: untyped API J
if not xrefs or not isinstance(xrefs, list):
return None

# ⚡ Bolt: Use walrus operator (:=) instead of nested `for entry in [cls._build_reactome_entry(xref)]`
# This avoids creating single-element lists and extra iteration overhead, making the comprehension ~5% faster.
reactome_refs = [
entry
for xref in xrefs
if isinstance(xref, dict) and xref.get("database") == "Reactome"
for entry in [cls._build_reactome_entry(xref)]
if entry is not None
if (entry := cls._build_reactome_entry(xref)) is not None
]

return (
Expand Down
Loading