Skip to content

Refactor diagram scripts to deprecated wrappers with centralized implementation#2434

Merged
SatoryKono merged 10 commits intomainfrom
claude/merge-main-tmp01-01-MestR
Mar 1, 2026
Merged

Refactor diagram scripts to deprecated wrappers with centralized implementation#2434
SatoryKono merged 10 commits intomainfrom
claude/merge-main-tmp01-01-MestR

Conversation

@SatoryKono
Copy link
Owner

@SatoryKono SatoryKono commented Mar 1, 2026

Summary

Consolidates diagram validation and processing logic by converting 10+ standalone scripts into lightweight deprecated wrappers that delegate to a centralized scripts/diagrams/ module. This eliminates code duplication, improves maintainability, and establishes a single source of truth for diagram tooling.

Changes

  • Script consolidation: Converted the following scripts to deprecated wrappers:

    • lint_diagrams.py
    • uniform_diagram_sizes.py
    • run_diagram_nightly_suite.py
    • prune_orphan_nodes.py
    • normalize_node_sizes.py
    • check_diagram_quality_gates.py
    • check_svg_text_visibility.py
    • add_svg_text_fallback.py
    • inject_svg_styles.py
    • check_diagram_artifacts.py
    • report_diagram_padding.py
    • summarize_diagram_lint.py
    • fix_diagram_links.py
    • fix_sequence_nbsp.py
    • mermaid_prune_orphans.py

  • Removed: render_diagrams.py (legacy compatibility script)

  • Updated: Bash runners (run_diagram_checks.sh, validate_mermaid_syntax.sh) to minimal stubs

  • Diagram metadata: Added %% @type and %% @level metadata to 100+ diagram files for improved classification and rendering control

  • CSS restructuring: Reorganized custom.css with structured comments documenting CSS parameter purposes

  • CI/workflow updates: Updated GitHub Actions workflows to reference new centralized diagram tooling paths

  • Documentation: Updated references in Makefile, README, and diagram guides to point to new script locations

Checklist

  • make lint passes
  • make test passes
  • No hardcoded secrets or credentials
  • Architecture tests pass
  • Documentation updated (Makefile, README, workflow files)
  • Follows Conventional Commits format

Notes

All deprecated wrappers maintain backward compatibility by delegating to scripts/diagrams/ counterparts via runpy.run_path(). Existing CI pipelines and local workflows continue to function without modification.

https://claude.ai/code/session_015hwjqHmxRywVWxEKzTPNpk

SatoryKono and others added 10 commits March 1, 2026 16:34
@SatoryKono
1
338bc98
@SatoryKono
1
c5226de
@SatoryKono
1
c6e7713
@SatoryKono
1
0691eb8
@SatoryKono
1
1357f1c
@SatoryKono
1
860f489
@SatoryKono
1
54c1932
@SatoryKono
1
128fd02
@SatoryKono
1
41b69b6
@claude
Merge remote-tracking branch 'origin/TMP01-01' into claude/merge-main…
dabadeb 
…-tmp01-01-MestR

# Conflicts:
#	docs/02-architecture/mmd-diagrams/architecture/10-resilience-patterns.mmd
#	docs/02-architecture/mmd-diagrams/architecture/svg/INDEX.md
#	docs/02-architecture/mmd-diagrams/class-diagrams/png/INDEX.md
#	docs/02-architecture/mmd-diagrams/class-diagrams/svg/INDEX.md
#	docs/02-architecture/mmd-diagrams/foundation/40-application-core-collaboration.mmd
#	docs/02-architecture/mmd-diagrams/theme/custom.css
#	docs/02-architecture/mmd-diagrams/views/01-high-level-dataflow.mermaid
#	docs/02-architecture/mmd-diagrams/views/01-high-level-infra.mermaid
#	docs/02-architecture/mmd-diagrams/views/05-layers-interaction-dataflow.mermaid
#	docs/02-architecture/mmd-diagrams/views/08-complete-etl-workflow-full.mermaid
#	docs/02-architecture/mmd-diagrams/views/08-domain-ddd-domain.mermaid
#	docs/02-architecture/mmd-diagrams/views/08-domain-ddd-full.mermaid
#	docs/02-architecture/mmd-diagrams/views/08-domain-ddd-infra.mermaid
#	docs/02-architecture/mmd-diagrams/views/08-domain-ddd-overview.mermaid
#	docs/02-architecture/mmd-diagrams/views/10-infrastructure-layer-class-diagram-dataflow.mermaid
#	docs/02-architecture/mmd-diagrams/views/12-local-deployment-architecture-domain.mermaid
#	docs/02-architecture/mmd-diagrams/views/12-local-deployment-architecture-full.mermaid
#	docs/02-architecture/mmd-diagrams/views/14-provider-health-states-overview.mermaid
#	docs/02-architecture/mmd-diagrams/views/21-activity-entity-data-flow-full.mermaid
#	docs/02-architecture/mmd-diagrams/views/28-composition-root-di-graph-dataflow.mermaid
#	docs/02-architecture/mmd-diagrams/views/28-composition-root-di-graph-domain.mermaid
#	docs/02-architecture/mmd-diagrams/views/28-composition-root-di-graph-infra.mermaid
#	docs/02-architecture/mmd-diagrams/views/29-composite-pipeline-workflow-domain.mermaid
#	docs/02-architecture/mmd-diagrams/views/29-composite-pipeline-workflow-full.mermaid
#	docs/02-architecture/mmd-diagrams/views/29-composite-pipeline-workflow-infra.mermaid
#	docs/02-architecture/mmd-diagrams/views/31-pipeline-run-lifecycle-dataflow.mermaid
#	docs/02-architecture/mmd-diagrams/views/32-single-record-journey-full.mermaid
#	docs/02-architecture/mmd-diagrams/views/34-batch-processing-flow-dataflow.mermaid
#	docs/02-architecture/mmd-diagrams/views/34-batch-processing-flow-overview.mermaid
#	docs/02-architecture/mmd-diagrams/views/35-bootstrap-sequence-domain.mermaid
#	docs/02-architecture/mmd-diagrams/views/35-bootstrap-sequence-infra.mermaid
#	docs/02-architecture/mmd-diagrams/views/35-bootstrap-sequence-overview.mermaid
#	docs/02-architecture/mmd-diagrams/views/36-architecture-principles-mindmap-domain.mermaid
#	docs/02-architecture/mmd-diagrams/views/36-architecture-principles-mindmap-overview.mermaid
#	docs/02-architecture/mmd-diagrams/views/39-medallion-invariants-domain.mermaid
#	docs/02-architecture/mmd-diagrams/views/39-medallion-invariants-full.mermaid
#	docs/02-architecture/mmd-diagrams/views/39-medallion-invariants-infra.mermaid
#	docs/02-architecture/mmd-diagrams/views/41-error-classification-tree-dataflow.mermaid
#	docs/02-architecture/mmd-diagrams/views/41-error-classification-tree-domain.mermaid
#	docs/02-architecture/mmd-diagrams/views/41-error-classification-tree-infra.mermaid
#	docs/02-architecture/mmd-diagrams/views/44-cross-provider-enrichment-domain.mermaid
#	docs/02-architecture/mmd-diagrams/views/44-cross-provider-enrichment-full.mermaid
#	docs/02-architecture/mmd-diagrams/views/44-cross-provider-enrichment-infra.mermaid
#	docs/02-architecture/mmd-diagrams/views/48-composite-phase-lifecycle-dataflow.mermaid
#	docs/02-architecture/mmd-diagrams/views/48-composite-phase-lifecycle-overview.mermaid
#	docs/02-architecture/mmd-diagrams/views/50-exception-hierarchy-domain.mermaid
#	docs/02-architecture/mmd-diagrams/views/50-exception-hierarchy-infra.mermaid
#	docs/02-architecture/mmd-diagrams/views/50-exception-hierarchy-overview.mermaid
#	scripts/fix_sequence_nbsp.py
#	scripts/lint_diagrams.py
@chatgpt-codex-connector
Copy link

chatgpt-codex-connector bot commented Mar 1, 2026

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@SatoryKono SatoryKono merged commit 4a7a0ec into main Mar 1, 2026
7 of 33 checks passed
@SatoryKono SatoryKono deleted the claude/merge-main-tmp01-01-MestR branch March 1, 2026 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SatoryKono @claude