Skip to content

fix: avoid retrying callable backends on TypeError#14

Open
OBaruch wants to merge 1 commit into
SantanderAI:mainfrom
OBaruch:fix/callable-typeerror-retry
Open

fix: avoid retrying callable backends on TypeError#14
OBaruch wants to merge 1 commit into
SantanderAI:mainfrom
OBaruch:fix/callable-typeerror-retry

Conversation

@OBaruch

@OBaruch OBaruch commented Jun 23, 2026

Copy link
Copy Markdown

Description

Prevents CallableClient from retrying a backend when the backend itself
raises TypeError.

The previous implementation used a broad except TypeError to fall back from
the full keyword call to the minimal (messages) signature. That also caught
errors raised inside the backend, causing a second invocation, duplicate side
effects, and loss of the original failure context.

The client now inspects and binds the callable signature before invocation. It
keeps support for both documented callable forms while ensuring the backend is
executed at most once per request. Unsupported signatures are rejected before
execution.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that changes existing behavior)
  • Documentation only

Checklist

  • CLA signed when prompted by CLA Assistant
  • Commit follows Conventional Commits
  • Tests added for the fixed behavior
  • Changelog updated
  • No secrets, credentials, internal URLs, or proprietary content included

@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@OBaruch

OBaruch commented Jun 23, 2026

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

github-actions Bot added a commit that referenced this pull request Jun 23, 2026
@OBaruch OBaruch marked this pull request as ready for review June 23, 2026 21:44
@OBaruch OBaruch requested a review from a team as a code owner June 23, 2026 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant