fix: avoid retrying callable backends on TypeError#14
Open
OBaruch wants to merge 1 commit into
Open
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prevents
CallableClientfrom retrying a backend when the backend itselfraises
TypeError.The previous implementation used a broad
except TypeErrorto fall back fromthe full keyword call to the minimal
(messages)signature. That also caughterrors raised inside the backend, causing a second invocation, duplicate side
effects, and loss of the original failure context.
The client now inspects and binds the callable signature before invocation. It
keeps support for both documented callable forms while ensuring the backend is
executed at most once per request. Unsupported signatures are rejected before
execution.
Type of change
Checklist