os/mm/mm_heap: Dump previous to previous node in heap dump.#7147
Merged
sunghan-chang merged 1 commit intoSamsung:masterfrom Feb 11, 2026
Merged
os/mm/mm_heap: Dump previous to previous node in heap dump.#7147sunghan-chang merged 1 commit intoSamsung:masterfrom
sunghan-chang merged 1 commit intoSamsung:masterfrom
Conversation
vivek1-j
force-pushed
the
prev_to_prev_node_dump
branch
from
26ff49c to
586c874
Compare
Contributor
sunghan-chang
left a comment
sunghan-chang
left a comment
There was a problem hiding this comment.
The prev to prev node is necessary when the prev node is a stack.
Is it possible to show it with conditional?
Contributor
|
I think user could be confused with too many information. |
vivek1-j
force-pushed
the
prev_to_prev_node_dump
branch
from
586c874 to
08cefcf
Compare
Contributor
Author
I have added check. |
Contributor
Author
Added the dump in condition |
ewoodev
reviewed
Feb 10, 2026
Comment on lines
+150
to
+152
| if (prev->pid < 0) { //-ve value means prev is stack allocated node, therefore we will print prev to prev node. | ||
| mm_dump_node(prevtoprev, "PREV TO PREV NODE"); | ||
| } |
Contributor
There was a problem hiding this comment.
need to add #ifdef CONFIG_DEBUG_MM_HEAPINFO
| start_corrupt = (uint32_t)prevtoprev + prevtoprev->size - MM_LAST_CORRUPT_SIZE; | ||
| } | ||
| } else if (prev->size <= MM_LAST_CORRUPT_SIZE) { | ||
| start_corrupt = (uint32_t)prevtoprev; |
Contributor
There was a problem hiding this comment.
Isn't this right? start_corrupt = (uint32_t)prev;
Contributor
Author
There was a problem hiding this comment.
Yes, thanks for catching that.
When we get a stackoverflow, it could be a stackoverflow OR previous node could corrupt next node (stack).
To know which one corrupts, we should check previous node of the previous node (stack).
Now we are priting 3 nodes like:
prev to prev node > prev node > corrupted node in forward traversal.
Signed-Off By: Vivek Jain (vivek1.j@samsung.com)
vivek1-j
force-pushed
the
prev_to_prev_node_dump
branch
from
08cefcf to
2d9c3f9
Compare
seokhun-eom24
approved these changes
Feb 11, 2026
sunghan-chang
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we get a stackoverflow, it could be a stackoverflow OR previous node could corrupt next node (stack). To know which one corrupts, we should check previous node of the previous node (stack). Now we are priting 3 nodes like:
prev to prev node > prev node > corrupted node in forward traversal.
Signed-Off By: Vivek Jain (vivek1.j@samsung.com)