os/drivers/cpu, apps/system: Add CPU driver interface and test app#7033
Open
mukku-suneel wants to merge 3 commits intoSamsung:masterfrom
Open
os/drivers/cpu, apps/system: Add CPU driver interface and test app#7033mukku-suneel wants to merge 3 commits intoSamsung:masterfrom
mukku-suneel wants to merge 3 commits intoSamsung:masterfrom
Conversation
Contributor
Author
|
This PR depends on PR #7028 |
mukku-suneel
force-pushed
the
cpu_on_off_driver
branch
4 times, most recently
from
3a55ddb to
220a207
Compare
Contributor
-need to remove it |
mukku-suneel
force-pushed
the
cpu_on_off_driver
branch
2 times, most recently
from
38deec1 to
771c4b9
Compare
mukku-suneel
changed the title
Contributor
|
LGTM |
anjana348
reviewed
Nov 12, 2025
mukku-suneel
force-pushed
the
cpu_on_off_driver
branch
2 times, most recently
from
66f8606 to
3785ca7
Compare
mukku-suneel
force-pushed
the
cpu_on_off_driver
branch
from
3785ca7 to
5b80ffc
Compare
Contributor
|
Hello @mukku-suneel |
mukku-suneel
force-pushed
the
cpu_on_off_driver
branch
from
5b80ffc to
c68e8a8
Compare
Contributor
Author
Hello @seokhun-eom24 |
ewoodev
reviewed
Feb 2, 2026
mukku-suneel
force-pushed
the
cpu_on_off_driver
branch
2 times, most recently
from
d01ca81 to
990f28f
Compare
ewoodev
reviewed
Feb 10, 2026
mukku-suneel
force-pushed
the
cpu_on_off_driver
branch
3 times, most recently
from
92836c0 to
da56183
Compare
Contributor
|
Is there any reason for turn config on only |
mukku-suneel
force-pushed
the
cpu_on_off_driver
branch
from
da56183 to
ec2fcf4
Compare
Contributor
Author
Enabled the configs in every SMP enabled defconfig. |
ewoodev
reviewed
Feb 19, 2026
Comment on lines
82
to
83
Contributor
Contributor
There was a problem hiding this comment.
sched_migrate_task API has preconditions.
- Call must be made from context which blocks preemption.
- Before making this call, corresponding bit in g_active_cpus_mask must be cleared.
For testing purposes only, we can do it here.
@rish-sg Do you have anything to add?
Contributor
Author
There was a problem hiding this comment.
Could you please add sched_migrate_tasks(cpu); before sched_cpuoff?
Added.
But after adding sched_migrate_tasks(cpu); before sched_cpuoff,
we can't disable cpu1 since corresponding bit in g_active_cpus_mask not cleared.
Log:
TASH>>
TASH>>cpuctrl off 1
TASH>>powering down cpu1!
cpu_ioctl: ERROR: Failed to migrate tasks from CPU1: -22
Failed to disable CPU1: error 22
TASH>>
ec2fcf4 to
220f3d2
Compare
Add character driver for Secondary CPUs management operations through /dev/cpuX device nodes. Provides ioctl interface for CPU enable/disable and state query operations. This driver enables userspace applications and test utilities to control CPU states and perform cpu on/off operations through standard interface.
…esting Add cputest application with shell commands for testing CPU driver functionality. Provides commands to enable/disable secondary CPUs and check CPU status through device interface. Shell commands added: - cpuctrl on <cpu_id>: Power on specified CPU - cpuctrl off <cpu_id>: Power off specified CPU - cpuctrl status: Show status of all Secondary CPUs - cpuctrl help : Show the help message Test Results: TASH>> TASH>> TASH>>cpuctrl status TASH>>cpu state for cpu1: 0 (running) TASH>> TASH>> TASH>> TASH>>smp TASH>> Main[0]: Running on CPU0 Main[0]: Initializing barrier Running SMP test with AMP configuration Thread[1]: Started Thread[1]: Running on CPU0 Main[0]: Thread 1 created Thread[2]: Started Thread[2]: Running on CPU1 Main[0]: Thread 2 created Thread[3]: Started Thread[3]: Running on CPU0 Main[0]: Thread 3 created Thread[4]: Started Thread[4]: Running on CPU1 Main[0]: Thread 4 created Thread[5]: Started Thread[5]: Running on CPU0 Main[0]: Thread 5 created Thread[6]: Started Thread[6]: Running on CPU1 Main[0]: Thread 6 created Thread[7]: Started Thread[7]: Running on CPU0 Main[0]: Thread 7 created Thread[8]: Started Thread[8]: Running on CPU1 Main[0]: Thread 8 created Thread[2]: Calling pthread_barrier_wait() Thread[1]: Calling pthread_barrier_wait() Thread[4]: Calling pthread_barrier_wait() Thread[3]: Calling pthread_barrier_wait() Thread[5]: Calling pthread_barrier_wait() Thread[6]: Calling pthread_barrier_wait() Thread[7]: Calling pthread_barrier_wait() Thread[8]: Calling pthread_barrier_wait() Thread[8]: Back with ret=PTHREAD_BARRIER_SERIAL_THREAD (I AM SPECIAL) Thread[1]: Back with ret=0 (I am not special) Thread[3]: Back with ret=0 (I am not special) Thread[5]: Back with ret=0 (I am not special) Thread[7]: Back with ret=0 (I am not special) Thread[2]: Back with ret=0 (I am not special) Thread[4]: Back with ret=0 (I am not special) Thread[6]: Back with ret=0 (I am not special) Thread[8]: Done Thread[2]: Done Thread[4]: Done Thread[6]: Done Thread[1]: Done Thread[3]: Done Thread[5]: Done Main[0]: Thread 1 completed with result=0 Thread[7]: Done Main[0]: Thread 2 completed with result=0 Main[0]: Thread 3 completed with result=0 Main[0]: Thread 4 completed with result=0 Main[0]: Thread 5 completed with result=0 Main[0]: Thread 6 completed with result=0 Main[0]: Thread 7 completed with result=0 Main[0]: Thread 8 completed with result=0 TASH>> TASH>> TASH>> TASH>> TASH>>cpuctrl off 1 TASH>>powering down cpu1! cpu1 successfully disabled state: 1 (offline) TASH>> TASH>> TASH>> TASH>>cpuctrl status TASH>>cpu state for cpu1: 1 (offline) TASH>> TASH>> TASH>> TASH>> TASH>>smp TASH>> Main[0]: Running on CPU0 Main[0]: Initializing barrier Running SMP test with AMP configuration Thread[1]: Started Thread[1]: Running on CPU0 Main[0]: Thread 1 created Thread[2]: Started Thread[2]: Running on CPU0 Main[0]: Thread 2 created Thread[3]: Started Thread[3]: Running on CPU0 Main[0]: Thread 3 created Thread[4]: Started Thread[4]: Running on CPU0 Main[0]: Thread 4 created Thread[5]: Started Thread[5]: Running on CPU0 Main[0]: Thread 5 created Thread[6]: Started Thread[6]: Running on CPU0 Main[0]: Thread 6 created Thread[7]: Started Thread[7]: Running on CPU0 Main[0]: Thread 7 created Thread[8]: Started Thread[8]: Running on CPU0 Main[0]: Thread 8 created Thread[1]: Calling pthread_barrier_wait() Thread[3]: Calling pthread_barrier_wait() Thread[5]: Calling pthread_barrier_wait() Thread[7]: Calling pthread_barrier_wait() Thread[2]: Calling pthread_barrier_wait() Thread[4]: Calling pthread_barrier_wait() Thread[6]: Calling pthread_barrier_wait() Thread[8]: Calling pthread_barrier_wait() Thread[8]: Back with ret=PTHREAD_BARRIER_SERIAL_THREAD (I AM SPECIAL) Thread[1]: Back with ret=0 (I am not special) Thread[3]: Back with ret=0 (I am not special) Thread[5]: Back with ret=0 (I am not special) Thread[7]: Back with ret=0 (I am not special) Thread[2]: Back with ret=0 (I am not special) Thread[4]: Back with ret=0 (I am not special) Thread[6]: Back with ret=0 (I am not special) Thread[1]: Done Thread[3]: Done Thread[7]: Done Thread[5]: Done Main[0]: Thread 1 completed with result=0 Thread[6]: Done Thread[8]: Done Thread[2]: Done Thread[4]: Done Main[0]: Thread 2 completed with result=0 Main[0]: Thread 3 completed with result=0 Main[0]: Thread 4 completed with result=0 Main[0]: Thread 5 completed with result=0 Main[0]: Thread 6 completed with result=0 Main[0]: Thread 7 completed with result=0 Main[0]: Thread 8 completed with result=0 TASH>> TASH>> TASH>> TASH>>cpuctrl on 1 TASH>>powering up cpu1! cpu1 successfully enabled state: 0 (running) TASH>> TASH>> TASH>>cpuctrl status TASH>>cpu state for cpu1: 0 (running) TASH>> TASH>> TASH>> TASH>>smp TASH>> Main[0]: Running on CPU0 Main[0]: Initializing barrier Running SMP test with AMP configuration Thread[1]: Started Thread[1]: Running on CPU0 Main[0]: Thread 1 created Thread[2]: Started Thread[2]: Running on CPU1 Main[0]: Thread 2 created Thread[3]: Started Thread[3]: Running on CPU0 Main[0]: Thread 3 created Thread[4]: Started Thread[4]: Running on CPU1 Main[0]: Thread 4 created Thread[5]: Started Thread[5]: Running on CPU0 Main[0]: Thread 5 created Thread[6]: Started Thread[6]: Running on CPU1 Main[0]: Thread 6 created Thread[7]: Started Thread[7]: Running on CPU0 Main[0]: Thread 7 created Thread[8]: Started Thread[8]: Running on CPU1 Main[0]: Thread 8 created Thread[2]: Calling pthread_barrier_wait() Thread[1]: Calling pthread_barrier_wait() Thread[4]: Calling pthread_barrier_wait() Thread[3]: Calling pthread_barrier_wait() Thread[5]: Calling pthread_barrier_wait() Thread[6]: Calling pthread_barrier_wait() Thread[7]: Calling pthread_barrier_wait() Thread[8]: Calling pthread_barrier_wait() Thread[8]: Back with ret=PTHREAD_BARRIER_SERIAL_THREAD (I AM SPECIAL) Thread[1]: Back with ret=0 (I am not special) Thread[3]: Back with ret=0 (I am not special) Thread[5]: Back with ret=0 (I am not special) Thread[7]: Back with ret=0 (I am not special) Thread[2]: Back with ret=0 (I am not special) Thread[4]: Back with ret=0 (I am not special) Thread[6]: Back with ret=0 (I am not special) Thread[8]: Done Thread[2]: Done Thread[4]: Done Thread[6]: Done Thread[1]: Done Thread[3]: Done Thread[5]: Done Main[0]: Thread 1 completed with result=0 Thread[7]: Done Main[0]: Thread 2 completed with result=0 Main[0]: Thread 3 completed with result=0 Main[0]: Thread 4 completed with result=0 Main[0]: Thread 5 completed with result=0 Main[0]: Thread 6 completed with result=0 Main[0]: Thread 7 completed with result=0 Main[0]: Thread 8 completed with result=0 TASH>> TASH>> TASH>> TASH>>
…ration for rtl8730e Add CONFIG_CPU_DRIVER=y and CONFIG_SYSTEM_CPUCONTROL=y to rtl8730e board configurations to enable CPU driver support and CPU control app for CPU management operations.
mukku-suneel
force-pushed
the
cpu_on_off_driver
branch
from
220f3d2 to
9960913
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Secondary CPUs management interface with character driver interface,
test application and board configuration support.
CPU Driver:
Test Application:
Configuration:
Shell commands added: