Skip to content

Cute objects in cute bomb no longer repeat#10

Open
hoppermeister wants to merge 1 commit into
masterfrom
hoppermeister-master
Open

Cute objects in cute bomb no longer repeat#10
hoppermeister wants to merge 1 commit into
masterfrom
hoppermeister-master

Conversation

@hoppermeister

Copy link
Copy Markdown
Collaborator

No description provided.

@lhigginbotham lhigginbotham left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now with technically less random! I'm afraid I can't support this PR 👎

@SammyIsra SammyIsra left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this prevent cute bombs to have repeated links? Also, can you prevent super huge bombs? Ideally, no one would get a 20+ bomb.

@SammyIsra SammyIsra left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, since we have a limit of 10k history on Slack, can you aggregate all links into a single message and send it once? Instead of sending one message per ink.

@hoppermeister

Copy link
Copy Markdown
Collaborator Author

Super late but no- putting all of the links in one message would only have one thumbnail, ruining the point of the 'bomb'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants