Skip to content

Improve handling of endianness#514

Open
ds5678 wants to merge 1 commit intoSamboyCoding:developmentfrom
AssetRipper:endianess-improvements
Open

Improve handling of endianness#514
ds5678 wants to merge 1 commit intoSamboyCoding:developmentfrom
AssetRipper:endianess-improvements

Conversation

@ds5678
Copy link
Contributor

@ds5678 ds5678 commented Feb 5, 2026

  • Use BinaryPrimitives instead of BitConverter
  • Add IsLittleEndian property to EndianAwareBinaryReader
  • Remove byte array allocations for reading big endian primitives

* Use BinaryPrimitives instead of BitConverter
* Add IsLittleEndian property to EndianAwareBinaryReader
* Remove byte array allocations for reading big endian primitives
@coveralls
Copy link

Pull Request Test Coverage Report for Build 21706317451

Details

  • 10 of 20 (50.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 34.393%

Changes Missing Coverage Covered Lines Changed/Added Lines %
LibCpp2IL/ClassReadingBinaryReader.cs 1 2 50.0%
LibCpp2IL/BinaryReaderHelpers.cs 0 9 0.0%
Totals Coverage Status
Change from base Build 21104268457: 0.02%
Covered Lines: 4210
Relevant Lines: 10893

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants