fix: serve/web runs never persist turn metrics or context estimates#837
Closed
sam-saffron-jarvis wants to merge 1 commit into
Closed
fix: serve/web runs never persist turn metrics or context estimates#837sam-saffron-jarvis wants to merge 1 commit into
sam-saffron-jarvis wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
cmd/serve_runtime.goso the existingSetTurnCompletedCallbacknow persists per-turn metrics for serve/web runs viastore.UpdateMetrics(...).store.UpdateContextEstimate(...), matching the existing CLI/TUI/Telegram behavior.sessionMetacounters and persisted context estimate when those writes succeed so active serve sessions stay consistent with stored session state.cmd/serve_runtime_test.gothat exercises a multi-turn tool run and verifies both metrics and context estimates are persisted.Why this is high-value
Serve/web sessions were successfully appending transcript rows but silently leaving session accounting stale on normal completion. That meant:
llm_turns,tool_calls, and token totals could stay zero or outdatedlast_total_tokens/last_message_countwere not saved for resumed web sessionsThis fix is small, targeted, and aligns serve/web with already-shipped persistence behavior in ask/TUI/Telegram.
Validation
go test ./cmd -run TestServeRuntimeRunPersistsTurnMetricsAndContextEstimate -count=1gofmt -w cmd/serve_runtime.go cmd/serve_runtime_test.gogo build ./...go test ./...git diff --statandgit diff --check