fix: WebRTC data-channel requests keep running after disconnect and can hang peer cleanup#834
Closed
sam-saffron-jarvis wants to merge 1 commit into
Closed
Conversation
…an hang peer cleanup
Owner
|
Closing as requested: the high-confidence fixes have been applied or superseded in the current working tree. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
runDataChanneland cancel it before waiting for in-flight handlers during disconnect, idle-timeout, and reader-exit teardown pathsdispatchRequestto create a per-request child context and taughtdcResponseWriterto fail closed by canceling that request context on the first send errorr.Context().Done()is released when response-frame delivery failsWhy this is high-value
A closed browser tab or broken data channel could previously leave long-lived WebRTC handlers running under the peer's long-lived context, while peer teardown blocked in
wg.Wait(). That can strand streaming/v1/responseswork, model runs, and goroutines until the handler exits on its own. This fix makes disconnects and transport write failures actively cancel request contexts, so cleanup and reconnect behavior are reliable instead of waiting on orphaned handlers.Validation
gofmt -w internal/webrtc/peer.go internal/webrtc/peer_test.gogo build ./...go test ./...git diff --check