fix: non-progressive ask leaks the provider stream when the output consumer dies early#832
Closed
sam-saffron-jarvis wants to merge 1 commit into
Closed
Conversation
…nsumer dies early
Owner
|
Closing as requested: the high-confidence fixes have been applied or superseded in the current working tree. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
askstreaming path under a childcontext.WithCancelengine.Stream,adapter.ProcessStream, and the foreground stream consumersemitSessionStarted, JSON write failures, renderer failures, plain-text write failures), cancel the child context before returning and wait for the producer goroutine to finishstream.Close()Why this is high-value
This fixes a real hot-path reliability leak in
askstreaming. Before this change, if the output consumer died early (for exampleask --json | head, a broken pipe, or a renderer failure),runAskcould return immediately while the provider stream goroutine stayed blocked behind the undrained event pipeline. That could leave an in-flight LLM request open until process exit, wasting provider time/tokens and sometimes hanging shell pipelines longer than necessary.With the new cancellation/join behavior, consumer failures now actively tear down the provider stream and wait for shutdown to complete deterministically.
Validation
gofmt -w cmd/ask.go cmd/ask_test.gogo build ./...go test ./...TestNonProgressiveConsumerWriteErrorCancellationUnblocksProducergit diff --check