fix: wait_for_jobs can return the wrong run because queue_agent discards the triggered run ID#831
Closed
sam-saffron-jarvis wants to merge 1 commit into
Closed
Conversation
…rds the triggered run ID
Owner
|
Closing as requested: the high-confidence fixes have been applied or superseded in the current working tree. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
run_idsand, when provided, polls/v2/runs/{run_id}so it waits on the exact triggered run instead of whichever run is latest for the jobjob_idssupport for backwards compatibility and added a focused test covering the exact-run polling pathWhy this is high-value
This fixes a user-visible reliability bug on the queued sub-agent path. Before this change, if the same queued job was triggered again before wait_for_jobs finished polling, the waiter could attach to the newer run and return the wrong status/output. Returning and consuming the trigger's run ID removes that ambiguity and prevents result corruption.
Validation
gofmt -w internal/tools/queue_agent.go internal/tools/queue_agent_test.gogo build ./...go test ./...git diff --check