fix: Agent on_complete hooks can hang ask forever and leak subprocesses#828
Closed
sam-saffron-jarvis wants to merge 1 commit into
Closed
fix: Agent on_complete hooks can hang ask forever and leak subprocesses#828sam-saffron-jarvis wants to merge 1 commit into
sam-saffron-jarvis wants to merge 1 commit into
Conversation
Owner
|
Implemented directly in main working tree with the same fixes and regression coverage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
runOnCompleteCapturein a boundedcontext.WithTimeoutsoaskno longer waits forever on a stuckagent.on_completehookon_completeexecution toexec.CommandContextplustools.PrepareCommand, which applies the same process-group cancellation/cleanup used by other command execution pathsWaitDelayforon_completesoaskalso returns when the parent shell exits but a backgrounded child keeps stdout/stderr openWhy this is high-value
agent.on_completeruns after the model has already successfully finished. Before this change, a slow or misbehaving hook could still leaveterm-llm askhung indefinitely at the very end, which is especially painful for scripts and automation. The old path also had no process-group cleanup, so broken hooks could leave stray subprocesses behind.This fix makes that tail-end hook fail open: the main
askresult still completes, while timeout/failure continues to surface as the existing non-fatal warning.Validation
gofmt -w cmd/ask.go cmd/ask_test.gogo build ./...go test ./cmd -run 'TestRunOnCompleteCapture_'go test ./...git diff --statgit diff --check