Fix pack exemption on velocity #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I haven't checked the cause yet, but I noticed a new behavior with this is that going to another proxy and exempting a pack, then changing servers within the same proxy will trigger a fresh pack reload. I suppose this is because if exempted, forcepack doesn't know what packs you have. I feel there should be an option to only send packs on proxy connect, and not on server changes within the same proxy? |
SamB440
approved these changes
May 7, 2025
Owner
|
Another option would be for the api to have a way to add resource packs to a player |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if I just missed this in my last PR but exemption didn't work on Velocity at least, the old exemption check was too late, the pack had already been sent to the user.