Skip to content

Bump follow-redirects from 1.15.4 to 1.15.6 in /frontend #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dependabot wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Bump follow-redirects from 1.15.4 to 1.15.6 in /frontend #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0bd9f13
#20: fixed scalability of images
SaltySkyPie Jan 28, 2024
f0353fa
Merge branch 'misc/20-code-readability' into 'main'
SaltySkyPie Jan 28, 2024
469c58d
Bump follow-redirects from 1.15.4 to 1.15.6 in /frontend
dependabot[bot] Mar 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions frontend/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

45 changes: 31 additions & 14 deletions frontend/src/modules/article-list/components/ArticleImage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,20 +3,37 @@ import { CardMedia } from '@mui/material'
export default function Image({ url }: { url?: string | null | undefined }) {
return (
<CardMedia
component="img"
loading="lazy"
sx={{
width: {
xs: '100%',
md: 450,
},
height: {
xs: 300,
md: 'auto',
},
}}
image={!url || !url.length ? '/placeholder.webp' : url}
alt={url || ''}
component="img"
loading="lazy"
sx={{
width: {
xs: '100%',
md: 450,
},
height: {
xs: 300,
md: 'auto',
},
minHeight: {
xs: 300,
md: 'auto',
},
maxHeight: {
xs: 300,
md: 'auto',
},
minWidth: {
xs: '100%',
md: 450
},
maxWidth: {
xs: '100%',
md: 450,
},
objectFit: 'cover',
}}
image={!url || !url.length ? '/placeholder.webp' : url}
alt={url || ''}
/>
)
}
2 changes: 1 addition & 1 deletion frontend/src/modules/article-list/components/ArticleListItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export default function ArticleListItem({ article }: { article: GetArticlesQuery
</Box>
<Link to={`/article/${article.id}`}>
<Box sx={{ display: 'flex', alignItems: 'center', p: 2 }}>
<Typography variant="h6">{t('readMore')}</Typography>
<Typography variant="body1">{t('readMore')}</Typography>
</Box>
</Link>
</CardActions>
Expand Down