Add Veriff request signing, structured error mapping, and unit tests#63
Merged
SaltProphet merged 1 commit intomainfrom Mar 6, 2026
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
VERIFF_SECRET_KEYso the API can verify request integrity.createVerificationSessionso the UI can differentiate configuration/auth/API problems.Description
createVeriffSessionSignature(payload, veriffSecretKey)which produces an HMAC-SHA256 hex signature and included it asX-HMAC-SIGNATUREon session creation requests.classifyVeriffResponseStatus(status)to map HTTP status codes to stable classifications (bad_request,auth_error,rate_limited,service_unavailable,api_error) and added structured logging on rejected responses containingstatus,classification, and a bounded response preview.createVerificationSession.src/lib/veriff.test.tscovering deterministic signature generation, status classification, presence of the signed header on outgoing requests, and mapping failure statuses to the expected user-safe messages.Testing
npm test -- src/lib/veriff.test.tsand all tests passed:Test Suites: 1 passed, Tests: 13 passed.fetchcalls, classification mapping, and that rejected responses are logged and mapped to user-safe messages.Codex Task