Skip to content

@W-21386533 MCP MRT Push now uses correct defaults based on detected project type#226

Merged
patricksullivansf merged 1 commit intomainfrom
psullivan.W-21386533.mcpMrtDefaultsFromDetectedProjectType
Mar 3, 2026
Merged

@W-21386533 MCP MRT Push now uses correct defaults based on detected project type#226
patricksullivansf merged 1 commit intomainfrom
psullivan.W-21386533.mcpMrtDefaultsFromDetectedProjectType

Conversation

@patricksullivansf
Copy link
Contributor

Summary

This fixes the MRT Push tool implemented with #110 to use project type aware defaults for the bundling step. This is necessary because the MRT Bundles for sfnext won't start with the default bundle glob patterns.

Testing

Use the testing setup from #110 but be sure to deploy the MRT project to an environment and verify it starts without error. Repeat the test for a pwv3 and sfnext project.

Dependencies

  • No net-new third-party dependencies were added
  • If net-new third-party dependencies were added, rationale/discussion is included and 3pl-approved is set by a maintainer

  • Tests pass (pnpm test)
  • Code is formatted (pnpm run format)

@yhsieh1
Copy link
Contributor

yhsieh1 commented Mar 2, 2026

@patricksullivansf The PR looks good. Are you able to test it out?

@patricksullivansf
Copy link
Contributor Author

@patricksullivansf The PR looks good. Are you able to test it out?

  • Tested with sfnext template app deployed with MCP MRT Push tool. It also required having the 4 mandatory ENV vars set (the error state appears the same for missing env as bad bundle, unless looking at MRT logs).
  • Tested with pwa kit v3 generated app.

There's a side discussion on ssrFunctionNodeVersion we might fold into this PR before we merge.

@patricksullivansf patricksullivansf force-pushed the psullivan.W-21386533.mcpMrtDefaultsFromDetectedProjectType branch from bc49943 to a30e220 Compare March 3, 2026 00:55
@yhsieh1
Copy link
Contributor

yhsieh1 commented Mar 3, 2026

@patricksullivansf The PR looks good. Are you able to test it out?

  • Tested with sfnext template app deployed with MCP MRT Push tool. It also required having the 4 mandatory ENV vars set (the error state appears the same for missing env as bad bundle, unless looking at MRT logs).
  • Tested with pwa kit v3 generated app.

There's a side discussion on ssrFunctionNodeVersion we might fold into this PR before we merge.

FYI: You could either use npx @salesforce/pwa-kit-dev@latest tail-logs --project [your project] --environment [target env] or b2c mrt tail-logs -p <project> -e <environment> to get MRT logs

@patricksullivansf patricksullivansf marked this pull request as ready for review March 3, 2026 18:17
@patricksullivansf patricksullivansf merged commit 8c6665b into main Mar 3, 2026
5 checks passed
@patricksullivansf patricksullivansf deleted the psullivan.W-21386533.mcpMrtDefaultsFromDetectedProjectType branch March 3, 2026 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants