@W-21386533 MCP MRT Push now uses correct defaults based on detected project type#226
Merged
patricksullivansf merged 1 commit intomainfrom Mar 3, 2026
Conversation
Contributor
|
@patricksullivansf The PR looks good. Are you able to test it out? |
yhsieh1
approved these changes
Mar 2, 2026
Contributor
Author
There's a side discussion on ssrFunctionNodeVersion we might fold into this PR before we merge. |
bc49943 to
a30e220
Compare
Contributor
FYI: You could either use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the MRT Push tool implemented with #110 to use project type aware defaults for the bundling step. This is necessary because the MRT Bundles for sfnext won't start with the default bundle glob patterns.
Testing
Use the testing setup from #110 but be sure to deploy the MRT project to an environment and verify it starts without error. Repeat the test for a pwv3 and sfnext project.
Dependencies
3pl-approvedis set by a maintainerpnpm test)pnpm run format)