Conversation
6a083b4 to
0a48d66
Compare
DipperTheDan
reviewed
Jan 5, 2026
Contributor
There was a problem hiding this comment.
suggestion(non-blocking): Confirm with QA but it might good to add an accessibility test for the bold prop, just to cover it.
Contributor
Author
There was a problem hiding this comment.
Checked with Sian since she has been looking at our tests and she didn't think it was necessary
mihai-albu-sage
previously approved these changes
Jan 8, 2026
nineteen88
previously approved these changes
Jan 14, 2026
Contributor
nineteen88
left a comment
There was a problem hiding this comment.
praise: a lot of solid refactors and tidying of the codebase as you go
Great work!
f12450c
a87bc17 to
78b64b0
Compare
DipperTheDan
previously approved these changes
Jan 22, 2026
mihai-albu-sage
previously approved these changes
Jan 22, 2026
divyajindel
previously approved these changes
Jan 22, 2026
6952b03
Updates styles to align with DS changes and updates to use new design-tokens.
DipperTheDan
approved these changes
Jan 22, 2026
divyajindel
approved these changes
Jan 22, 2026
tomdavies73
approved these changes
Jan 22, 2026
Collaborator
|
🎉 This PR is included in version 158.24.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
Linkuses new design tokens and removes underline on focus:Adds

boldprop toLink:Updates skip-link styles.

Current behaviour
Skip-link styles are out-of-date with DS.

Link colours are hardcoded hex values and underline is present on focus:

Checklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions