Skip to content

feat(link): updates styles and design-tokens#7648

Merged
nuria1110 merged 1 commit intomasterfrom
FE-7414
Jan 22, 2026
Merged

feat(link): updates styles and design-tokens#7648
nuria1110 merged 1 commit intomasterfrom
FE-7414

Conversation

@nuria1110
Copy link
Copy Markdown
Contributor

@nuria1110 nuria1110 commented Dec 1, 2025

Proposed behaviour

Link uses new design tokens and removes underline on focus:
image

Adds bold prop to Link:
image

Updates skip-link styles.
image

Current behaviour

Skip-link styles are out-of-date with DS.
image

Link colours are hardcoded hex values and underline is present on focus:
image

Checklist

  • Commits follow our style guide
  • Related issues linked in commit messages if required
  • Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
  • Playwright automation tests added or updated if required
  • Storybook added or updated if required
  • Translations added or updated (including creating or amending translation keys table in storybook) if required
  • Typescript d.ts file added or updated if required
  • Related docs have been updated if required

QA

  • Tested in provided StackBlitz sandbox/Storybook
  • Add new Playwright test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

Testing instructions

@nuria1110 nuria1110 self-assigned this Dec 1, 2025
@nuria1110 nuria1110 added the Work in progress This is a WIP PR so may not be ready for review label Dec 1, 2025
@nuria1110 nuria1110 force-pushed the FE-7414 branch 2 times, most recently from 6a083b4 to 0a48d66 Compare December 18, 2025 15:17
@nuria1110 nuria1110 added Pending Review Pending QA Pending UX QA Squad Front End and removed Work in progress This is a WIP PR so may not be ready for review labels Dec 18, 2025
@DipperTheDan DipperTheDan self-requested a review January 5, 2026 13:41
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion(non-blocking): Confirm with QA but it might good to add an accessibility test for the bold prop, just to cover it.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked with Sian since she has been looking at our tests and she didn't think it was necessary

@nineteen88 nineteen88 self-requested a review January 8, 2026 10:06
mihai-albu-sage
mihai-albu-sage previously approved these changes Jan 8, 2026
nineteen88
nineteen88 previously approved these changes Jan 14, 2026
Copy link
Copy Markdown
Contributor

@nineteen88 nineteen88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: a lot of solid refactors and tidying of the codebase as you go

Great work!

@nuria1110 nuria1110 marked this pull request as ready for review January 15, 2026 09:54
@nuria1110 nuria1110 requested review from a team as code owners January 15, 2026 09:54
@nuria1110 nuria1110 dismissed stale reviews from nineteen88 and mihai-albu-sage via f12450c January 16, 2026 14:16
@nuria1110 nuria1110 marked this pull request as draft January 16, 2026 15:48
@nuria1110 nuria1110 marked this pull request as ready for review January 19, 2026 10:05
@nuria1110 nuria1110 marked this pull request as draft January 19, 2026 10:10
@nuria1110 nuria1110 force-pushed the FE-7414 branch 2 times, most recently from a87bc17 to 78b64b0 Compare January 19, 2026 11:27
@nuria1110 nuria1110 marked this pull request as ready for review January 19, 2026 11:44
DipperTheDan
DipperTheDan previously approved these changes Jan 22, 2026
divyajindel
divyajindel previously approved these changes Jan 22, 2026
Updates styles to align with DS changes and updates to use new design-tokens.
@nuria1110 nuria1110 merged commit f745d5c into master Jan 22, 2026
28 checks passed
@nuria1110 nuria1110 deleted the FE-7414 branch January 22, 2026 16:10
@carbonci
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 158.24.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

8 participants