Skip to content

Add width limit to notification banners#253

Merged
7w1 merged 2 commits intoSableClient:devfrom
Vespe-r:small-notifications
Mar 14, 2026
Merged

Add width limit to notification banners#253
7w1 merged 2 commits intoSableClient:devfrom
Vespe-r:small-notifications

Conversation

@Vespe-r
Copy link
Contributor

@Vespe-r Vespe-r commented Mar 13, 2026

Description

Adds a limit to the width of the notification banner, so that it doesn't take up the entire width on larger screens unnecessarily.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@Vespe-r Vespe-r requested a review from a team March 13, 2026 22:32
Copy link
Contributor

@dozro dozro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me :3

@dozro
Copy link
Contributor

dozro commented Mar 14, 2026

@Vespe-r a changeset is missing :3

see: https://github.com/SableClient/Sable/actions/runs/23073140938/job/67039016437?pr=253

just something like:

---
default: patch
---

Add width limit to notification banners

should be enough

@7w1
Copy link
Member

7w1 commented Mar 14, 2026

@dozro @Vespe-r changesets use default: patch instead of sable: patch now :3

@dozro
Copy link
Contributor

dozro commented Mar 14, 2026

@dozro @Vespe-r changesets use default: patch instead of sable: patch now :3

ohhh, ooops

@7w1 7w1 enabled auto-merge March 14, 2026 12:38
@7w1 7w1 added this pull request to the merge queue Mar 14, 2026
Merged via the queue into SableClient:dev with commit 28073b5 Mar 14, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants