Skip to content

Bump Svelte to 5, update related dependencies #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
awesomephant merged 2 commits into from
Mar 17, 2025
Merged

Bump Svelte to 5, update related dependencies #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a59908b
Bump Svelte to 5, update related dependencies
awesomephant Mar 12, 2025
6907e80
Drop deprecated test
awesomephant Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 27 additions & 10 deletions components/.storybook/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,37 @@
import { dirname, join } from "path";
import type { StorybookConfig } from "@storybook/sveltekit";

function getAbsolutePath(value: string): any {
return dirname(require.resolve(join(value, "package.json")));
}

const config: StorybookConfig = {
stories: ["../src/**/*.mdx", "../src/**/*.stories.@(js|ts|svelte)"],
stories: [
"../src/**/*.stories.@(js|ts|svelte)",
"../src/**/*.mdx",
],

addons: [
"@storybook/addon-svelte-csf",
"@storybook/addon-links",
"@storybook/addon-essentials",
"@chromatic-com/storybook",
"@storybook/addon-interactions",
{
name: '@storybook/addon-svelte-csf',
options: {
legacyTemplate: true
}
},
getAbsolutePath("@storybook/addon-links"),
getAbsolutePath("@storybook/addon-essentials"),
getAbsolutePath("@chromatic-com/storybook"),
getAbsolutePath("@storybook/addon-interactions"),
getAbsolutePath("@storybook/addon-mdx-gfm")
],
framework: {
name: "@storybook/sveltekit",
name: getAbsolutePath("@storybook/sveltekit"),
options: {},
},
core: {
builder: '@storybook/builder-vite'

docs: {
autodocs: true
}
};
export default config;

export default config;
29 changes: 15 additions & 14 deletions components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,28 +26,29 @@
"@semantic-release/changelog": "^6.0.3",
"@semantic-release/git": "^10.0.1",
"@semantic-release/npm": "^12.0.1",
"@storybook/addon-essentials": "^8.4.5",
"@storybook/addon-interactions": "^8.4.5",
"@storybook/addon-links": "^8.4.5",
"@storybook/addon-svelte-csf": "^4.1.7",
"@storybook/blocks": "^8.4.5",
"@storybook/builder-vite": "^8.4.5",
"@storybook/svelte": "^8.4.5",
"@storybook/sveltekit": "^8.4.5",
"@storybook/test": "^8.4.5",
"@storybook/addon-essentials": "^8.6.4",
"@storybook/addon-interactions": "^8.6.4",
"@storybook/addon-links": "^8.6.4",
"@storybook/addon-mdx-gfm": "^8.6.4",
"@storybook/addon-svelte-csf": "^5.0.0-next.27",
"@storybook/blocks": "^8.6.4",
"@storybook/docs-tools": "^8.6.4",
"@storybook/svelte": "^8.6.4",
"@storybook/sveltekit": "^8.6.4",
"@storybook/test": "^8.6.4",
"@storybook/test-runner": "^0.19.1",
"@sveltejs/adapter-auto": "^3.0.0",
"@sveltejs/kit": "^2.0.0",
"@sveltejs/vite-plugin-svelte": "^3.0.0",
"@sveltejs/vite-plugin-svelte": "^5.0.3",
"concurrently": "^9.0.1",
"http-server": "^14.1.1",
"sass-embedded": "^1.78.0",
"semantic-release": "^24.1.2",
"storybook": "^8.4.5",
"svelte": "^4.2.7",
"storybook": "^8.6.4",
"svelte": "^5.23.0",
"svelte-check": "^4.0.0",
"typescript": "^5.0.0",
"vite": "^5.0.3",
"vite": "^6.0.0",
"wait-on": "^8.0.1"
},
"type": "module",
Expand All @@ -64,4 +65,4 @@
}
},
"version": "1.0.6"
}
}
11 changes: 2 additions & 9 deletions components/src/Autocomplete/Autocomplete.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { userEvent, within, expect, fn } from "@storybook/test"
import AutoComplete from "."
import AutoComplete from "./index.js"

export default {
title: "Example/Autocomplete",
Expand All @@ -23,10 +23,6 @@ export const Basic = {
},
}

const onSelect = fn((e) => {
return e.detail
})

export const Test = {
parameters: {
docs: {
Expand All @@ -39,9 +35,8 @@ export const Test = {
data: testData,
query: "",
placeholder: "Select a fruit",
event_select: onSelect,
},
play: async ({ args, canvasElement, step }) => {
play: async ({ canvasElement, step }) => {
const canvas = within(canvasElement)
const input = canvas.getByTestId("autocomplete-input")
await step("Select using the mouse", async () => {
Expand All @@ -51,7 +46,6 @@ export const Test = {
const bananasOption = canvas.getByText("Bananas")
await userEvent.click(bananasOption)
expect(input).toHaveValue("Bananas")
expect(onSelect).toHaveReturnedWith({ item: { label: "Bananas", value: "Bananas", details: {} } })
})
await userEvent.clear(input)
await step("Select using the keyboard", async () => {
Expand All @@ -61,7 +55,6 @@ export const Test = {
await userEvent.keyboard("{ArrowDown}")
await userEvent.keyboard("{Enter}")
expect(input).toHaveValue("Apples")
expect(onSelect).toHaveReturnedWith({ item: { label: "Apples", value: "Apples", details: {} } })
})
await userEvent.clear(input)
},
Expand Down
2 changes: 1 addition & 1 deletion components/src/HighlightCard/HighlightCard.stories.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
</DesignTokens>
</Story>

<Story name="Basic HighlightCard">
<Story name="Multiple HighlightCards">
<DesignTokens>
<div class="highlight-cards">
<HighlightCard
Expand Down
Loading