Adapt to changed semantics of "type f();" in C23#33
Open
jamesjer wants to merge 1 commit intoSWI-Prolog:masterfrom
Open
Adapt to changed semantics of "type f();" in C23#33jamesjer wants to merge 1 commit intoSWI-Prolog:masterfrom
jamesjer wants to merge 1 commit intoSWI-Prolog:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Fedora project is currently rebuilding all packages with a GCC 15 prerelease. GCC 15 changes the default C standard from C17 to C23. In C23, the semantics of
type f();have changed. Instead of meaning "a function that returns type with an unspecified parameter list" it now means the same astype f(void);; i.e., it asserts that there are no parameters. This makes the definition ofpl_function_tnot match its use, leading to a compilation error when building the swipy package.This PR makes C23 use the same definition as C++ for
pl_function_t. I have confirmed that the swipy package builds successfully with this change.