Skip to content

randomforest algorithm numpy and cpp primitive#677

Open
ct-clmsn wants to merge 103 commits intoSTEllAR-GROUP:masterfrom
ct-clmsn:randomforest
Open

randomforest algorithm numpy and cpp primitive#677
ct-clmsn wants to merge 103 commits intoSTEllAR-GROUP:masterfrom
ct-clmsn:randomforest

Conversation

@ct-clmsn
Copy link
Copy Markdown
Contributor

work in progress - pushed into phylanx upstream/master for review and commentary.

@ct-clmsn ct-clmsn changed the title Randomforest randomforest algorithm numpy and cpp Nov 30, 2018
@ct-clmsn
Copy link
Copy Markdown
Contributor Author

ct-clmsn commented Nov 30, 2018

the phylanx primitive needs more argument checking, the primitive implementation needs to be cleaned up (it's borrowed code from lra), and testing work...among other things (the phylanx cpp code formatting linter will break on this cpp code)! where should cpp unit test code go? @justwagle @Scheherzade

@ct-clmsn ct-clmsn added this to the 0.0.1 milestone Nov 30, 2018
@ct-clmsn ct-clmsn changed the title randomforest algorithm numpy and cpp randomforest algorithm numpy and cpp primitive Nov 30, 2018
@ct-clmsn ct-clmsn mentioned this pull request Dec 4, 2018
3 tasks
@ct-clmsn
Copy link
Copy Markdown
Contributor Author

ct-clmsn commented Dec 4, 2018

will need to add support for the following capabilities

  • implement training/prediction for randomforest
  • implement model store/load into/from phylanx::ir::dictionary
  • implement 'randomforest_fit' and 'randomforest_predict' functions in primitive
  • implement c++ unit test
  • implement python numpy unit test
  • implement python phylanx unit test

@ct-clmsn ct-clmsn requested a review from hkaiser December 5, 2018 04:34
ct-clmsn added 30 commits March 19, 2019 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants