Order perf: SDK output-vault filter + quote timing#88
Conversation
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (7)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 6 minutes and 20 seconds.Comment |
32bdba9 to
5d118de
Compare
How to use the Graphite Merge QueueAdd the label add-to-gt-merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
7d1d763 to
b14e075
Compare
5d118de to
4867e1c
Compare
findolor
left a comment
There was a problem hiding this comment.
I think the change in this PR belongs in the SDK level since processing the zero balance output vaults for an order doesn't make sense during quoting. We should keep the API simple without any custom logic.
So with that said I will open up a PR in raindex repo that handles this and we can bump raindex submodule here. Then we can remove the filtering logic
b14e075 to
4cd0e5a
Compare
4867e1c to
881be06
Compare
4cd0e5a to
b63a8ef
Compare
881be06 to
88749a1
Compare
…order endpoints Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
88749a1 to
a901a59
Compare

Summary
chunk_sizeto 4 to avoid exceeding public RPCeth_callgas limits.orders,quotes,total) to structured logs for order list performance monitoring.has_positive_output_vault_balance: Some(true)before quote fetching.Depends On
feat: add positive output vault balance order filter)lib/rain.orderbookto014016c699a2da4aa27d335bbf565e7347c2f762, which exposeshas_positive_output_vault_balance.Stack
alastair/nginx-hardening(Nginx hardening + infra updates #87)alastair/order-perf-optimizationsTest plan
nix develop -c cargo checknix develop -c cargo test routes::ordersnix develop -c cargo testnix develop -c rainix-rs-staticfails on existing clippytoo_many_argumentserrors insrc/routes/trades.rsroute handlers.