Check tx index state when trade lookups are empty#76
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
PR #50 already handles NotYetIndexed/202 via |
Summary
implement-trades-tx-hash202 not yet indexedonly when the transaction is still missing from the index, otherwise keep404for indexed transactions with no tradesWhy
The base branch already uses a direct transaction lookup, so the full lookup speedup from albionlabs/albion.rest.api is not needed here. The remaining gap is correctness: the route documents a
202response for not-yet-indexed transactions, but an empty direct lookup currently falls through to404.Validation
cargo fmtran successfullycargo test/cargo checkcould not be completed in this clone because the nestedrain.orderbookworkspace is missing generated contract artifacts (out/...json) required by its bindings build