Implement GET /v1/trades/tx/{tx_hash} endpoint#39
Closed
findolor wants to merge 4 commits into
Closed
Conversation
… fix Includes get_trades_for_transaction with polling, pub order_operations, and fix for nested transaction filter in SgTransactionTradesQuery.
Maps to HTTP 202 with code NOT_YET_INDEXED, logged at info level since it represents an expected transient state during indexing.
Queries all configured orderbooks for trades in a transaction, looks up order owners by hash, computes IO ratios and totals using Float math. Distinguishes 404 (no trades) vs 202 (not yet indexed). Converts trades.rs to module directory with get_by_tx and get_by_address sub-modules following the swap module pattern.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
findolor
changed the title
This was referenced Feb 18, 2026
Collaborator
Author
|
This is implemented properly in PR #50. |
graphite-app Bot
pushed a commit
that referenced
this pull request
May 7, 2026
Replaces #39. ## Dependent PR - rainlanguage/raindex#2497 ## Motivation See issues: - #28 ## Solution Adds the `GET /v1/trades/tx/{tx_hash}` endpoint that retrieves all trades associated with a given transaction hash. Updates `rain.orderbook` submodule, adds `NotYetIndexed` (202) error variant, restructures trades module into a directory with `TradesDataSource` trait, and includes 6 unit tests. ## Checks By submitting this for review, I'm confirming I've done the following: - [x] made this PR as small as possible - [x] unit-tested any new functionality - [x] linked any relevant issues or PRs - [ ] included screenshots (if this involves a front-end change) fix #28 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * New trades endpoints: fetch trades by transaction (fully implemented) and by address (placeholder/returns not implemented) with pagination and aggregated trade summaries. * **Bug Fixes** * Transactions still being indexed now return "Not yet indexed" (HTTP 202). * **Documentation** * OpenAPI updated for trades endpoints; coding guideline added recommending use of the address macro for Address constants. * **Tests** * Unit tests and fixtures added for trade-by-transaction scenarios. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
graphite-app Bot
pushed a commit
that referenced
this pull request
May 8, 2026
## Chained PRs - #50 ## Motivation See issues: - #29 - #30 Add a paginated endpoint to retrieve all trades for a given owner address across all configured orderbooks, with optional time filtering. Replaces #40, which was based on the old chain (#39) and couldn't merge cleanly. This branch is rebased on top of `implement-trades-tx-hash` (PR #50). ## Solution - Implement `GET /v1/trades/{address}` with pagination (`page`, `pageSize`) and optional time filters (`startTime`, `endTime`) - Extend `TradesDataSource` trait with `get_trades_for_owner` method that iterates all configured orderbooks and aggregates trades and total counts - Wire the route handler to use `RaindexTradesDataSource` via `run_with_client`, converting `TradesPaginationParams` into `PaginationParams` + `TimeFilter` with overflow validation - Map each `RaindexTrade` into `TradeByAddress` response type (tx_hash, formatted amounts, `TokenRef` for input/output tokens, order_hash, timestamp, block_number) - Compute pagination metadata (total_pages via `div_ceil`, has_more) - Update `rain.orderbook` submodule (`ff9578c` → `a612a4f`) to bring in `get_trades_for_owner()`, `RaindexTradesListResult`, `PaginationParams`, `TimeFilter`, `OrderbookIdentifierParams`, and address casing fix - Update `get_by_tx.rs` mock to implement the new trait method - Add AGENTS.md submodule rule: never modify submodule code directly - Unit tests for success (with amount/token assertions), empty results, query failure, 401 without auth, and 500 on bad config ## Checks By submitting this for review, I'm confirming I've done the following: - [x] made this PR as small as possible - [x] unit-tested any new functionality - [x] linked any relevant issues or PRs - [ ] included screenshots (if this involves a front-end change) fix #29 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Implemented the trade lookup endpoint for wallet addresses with pagination and time-range filtering capabilities. * **Documentation** * Added guidelines for managing external code dependencies. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chained PRs
Motivation
See issues:
Implements issue #28 (GET /v1/trades/tx/{tx_hash}) from the v1 route handlers tracking issue. This endpoint retrieves all trades associated with a given transaction hash, including per-trade IO ratios and aggregate totals.
Solution
tradesmodule from a single file into a directory withget_by_txandget_by_addresssubmodules for better separation of concernsget_trades_by_txhandler that queries all configured orderbook subgraphs for trades matching a transaction hash, fetches associated order data for owner addresses, and computes per-trade and aggregate IO ratios usingrain-math-floatNotYetIndexederror variant (ApiError::NotYetIndexed) returning 202 Accepted when the subgraph hasn't indexed the transaction yetrain.orderbooksubmodule to includeget_trades_for_transactionsupport and subgraph fixesTradesTxDataSourcetrait for testability, with comprehensive unit tests using mock data sourcesfuturescrate for concurrent order lookupsChecks
By submitting this for review, I'm confirming I've done the following:
fix #28