Skip to content

Use generic trades query for owner endpoint#110

Open
findolor wants to merge 1 commit into
feature/order-endpoint-batch-trade-queryfrom
feature/trades-owner-generic-query
Open

Use generic trades query for owner endpoint#110
findolor wants to merge 1 commit into
feature/order-endpoint-batch-trade-queryfrom
feature/trades-owner-generic-query

Conversation

@findolor
Copy link
Copy Markdown
Collaborator

@findolor findolor commented May 18, 2026

Summary

  • route GET /v1/trades/{owner} through the generic get_trades SDK path with an owner filter
  • preserve existing pagination, time filter, exact count, and response shape

Benchmark context

Local benchmark against the bootstrapped DB showed the owner-specific SDK path taking roughly 3-4s for 20-row pages. Using the generic owner-filtered trades query reduced the same endpoint to roughly 1-2.7s while keeping the same pagination totals.

Validation

  • nix develop -c cargo fmt
  • nix develop -c cargo check
  • nix develop -c rainix-rs-static

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 18, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fefeefff-2a6d-44b4-a9a0-89959577e860

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/trades-owner-generic-query

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Collaborator Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label add-to-gt-merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@findolor findolor self-assigned this May 18, 2026
@findolor findolor marked this pull request as ready for review May 18, 2026 09:37
@graphite-app graphite-app Bot force-pushed the feature/order-endpoint-batch-trade-query branch from 6ef2cb1 to b4fac6d Compare May 20, 2026 13:37
@graphite-app graphite-app Bot force-pushed the feature/order-endpoint-batch-trade-query branch from b4fac6d to f4de41e Compare May 20, 2026 13:38
@graphite-app graphite-app Bot force-pushed the feature/trades-owner-generic-query branch from 28254bc to ff1f985 Compare May 20, 2026 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants