[숲] 6주차 실습 #20
Open
[숲] 6주차 실습 #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iiuoon
reviewed
Nov 26, 2023
| memoTableView.dataSource = self | ||
| memoTableView.delegate = self | ||
| setNavigationBar() | ||
|
|
Member
There was a problem hiding this comment.
view.backgroundColor = .white 사용해주세요!
Comment on lines
+27
to
+28
| var titleArray: [String] = [] | ||
| var contentArray: [String] = [] |
Member
There was a problem hiding this comment.
Memo 구조체를 만들어서 한꺼번에 관리하는 걸 추천드려요!
struct Memo {
var title: String
var content: String
}
이런식으로요!
Comment on lines
+20
to
+23
| if (titleText.textColor == .lightGray || contentText.textColor == .gray || titleText.text.isEmpty || contentText.text.isEmpty) { | ||
| print("잘못된 제목 또는 내용입니다.") | ||
| return | ||
| } |
Member
There was a problem hiding this comment.
내용이 입력되지 않았을 때의 분기처리 하신 거 너무 좋습니다!!
그런데 로그만 띄우면 사용자는 알 수 없으니까
- 내용이 입력되지 않았을 때 '작성하기' 버튼 비활성화 하고 입력됐을 때 활성화 시키기
- 내용이 입력되지 않았을 때 '작성하기' 버튼 클릭하면 '제목 or 내용을 입력하세요' alert 띄우기
와 같은 코드를 구현하면 더 좋을 것 같아요!
Comment on lines
+71
to
+72
| make.leading.equalToSuperview().inset(50) | ||
| make.trailing.equalToSuperview().inset(50) |
Member
There was a problem hiding this comment.
make.leading.trailing.equalToSuperview().inset(50)
한 줄로 작성할 수 있습니다!
Comment on lines
+80
to
+81
| if isModified == true { | ||
| _ = self.navigationController?.popViewController(animated: false) |
Member
There was a problem hiding this comment.
수정이 됐을 때 바로 홈으로 이동하는 것보다는
이전 뷰인 메모 상세 뷰로 이동하는 게 더 자연스러울 것 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
#17
✨ 이슈 내용
메모장
📸 스크린샷(선택)
📚 레퍼런스 (또는 새로 알게 된 내용) 혹은 궁금한 사항들