Skip to content

Conversation

@sssd-bot
Copy link

This is an automatic backport of PR#8225 adding subid test to branch sssd-2-9, created by @danlavu.

Caution

@danlavu The patches did not apply cleanly. It is necessary to resolve conflicts before merging this pull request. Commits that introduced conflict are marked with CONFLICT!.

You can push changes to this pull request

git remote add sssd-bot git@github.com:sssd-bot/sssd.git
git fetch sssd-bot refs/heads/SSSD-sssd-backport-pr8225-to-sssd-2-9
git checkout SSSD-sssd-backport-pr8225-to-sssd-2-9
git push sssd-bot SSSD-sssd-backport-pr8225-to-sssd-2-9 --force

Original commits
449913a - adding subid test

Backported commits

  • 5f9a380 - CONFLICT! adding subid test

Conflicting Files Information (check for deleted and re-added files)

  • CONFLICT! adding subid test
On branch SSSD-sssd-backport-pr8225-to-sssd-2-9
You are currently cherry-picking commit 449913a8a.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   src/tests/system/tests/test_ipa.py

no changes added to commit (use "git add" and/or "git commit -a")

Original Pull Request Body

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request backports a new test file, src/tests/system/tests/test_ipa.py, which adds a comprehensive suite of system tests for SSSD's integration with FreeIPA. The new tests cover a wide range of features, including SSH public keys, ID views, HBAC rules, smart card authentication, and the subordinate ID (subid) functionality mentioned in the PR title. While the majority of the tests are well-structured, I've identified two tests related to ID views that don't actually validate SSSD's behavior on the client. Instead, they test the IPA server's command-line interface. These tests should be either corrected to verify client-side functionality or removed as they are out of scope for the SSSD test suite.

@danlavu
Copy link

danlavu commented Dec 10, 2025

@alexey-tikhonov Did you want this subid test ported to 2-9?

@alexey-tikhonov
Copy link
Member

@alexey-tikhonov Did you want this subid test ported to 2-9?

Imo it makes sense.

@danlavu danlavu force-pushed the SSSD-sssd-backport-pr8225-to-sssd-2-9 branch from 5f9a380 to ddb1de7 Compare January 6, 2026 16:05
Copy link
Contributor

@jakub-vavra-cz jakub-vavra-cz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants