these tests have been converted, removing the intg test#8241
Closed
danlavu wants to merge 1 commit intoSSSD:masterfrom
Closed
these tests have been converted, removing the intg test#8241danlavu wants to merge 1 commit intoSSSD:masterfrom
danlavu wants to merge 1 commit intoSSSD:masterfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the integration test file test_memory_cache.py as part of a conversion to a new test framework. The changes are straightforward, removing the test file and its reference in the Makefile. However, I've identified a regression test for a hash collision issue that appears to have been removed without being ported to the new test suite. This is a potentially critical omission.
Member
|
Please 'rebase' instead of 'merge'. |
danlavu
force-pushed
the
tests-rm-intg-memcache
branch
from
02840bd to
8d78d26
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.