Fix(databricks): Add column type only along materialized view comments#5617
Merged
themisvaltinos merged 4 commits intomainfrom Dec 3, 2025
Merged
Fix(databricks): Add column type only along materialized view comments#5617themisvaltinos merged 4 commits intomainfrom
themisvaltinos merged 4 commits intomainfrom
Conversation
themisvaltinos
commented
Dec 3, 2025
georgesittas
approved these changes
Dec 3, 2025
sqlmesh/core/engine_adapter/base.py
Outdated
| column_descriptions: t.Optional[t.Dict[str, str]] = None, | ||
| expressions: t.Optional[t.List[exp.PrimaryKey]] = None, | ||
| is_view: bool = False, | ||
| is_materialized_view: bool = False, |
Contributor
There was a problem hiding this comment.
Should this be is_materialized? And then we'd use it in combination with is_view.
Contributor
Author
There was a problem hiding this comment.
good point will pass the flag as is to avoid confusion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix to only add types in Databricks materialised views and not regular views (introduced here: #5578)
DOCS:
https://docs.databricks.com/aws/en/sql/language-manual/sql-ref-syntax-ddl-create-materialized-view#parameters
https://docs.databricks.com/aws/en/sql/language-manual/sql-ref-syntax-ddl-create-view