Fix: Mask credentials in duckdb attach for postgres, mysql logging#5528
Merged
themisvaltinos merged 2 commits intomainfrom Oct 10, 2025
Merged
Fix: Mask credentials in duckdb attach for postgres, mysql logging#5528themisvaltinos merged 2 commits intomainfrom
themisvaltinos merged 2 commits intomainfrom
Conversation
georgesittas
approved these changes
Oct 10, 2025
Contributor
georgesittas
left a comment
georgesittas
left a comment
There was a problem hiding this comment.
Looks good, a small (but important, imo) suggestion.
eakmanrq
approved these changes
Oct 10, 2025
georgesittas
approved these changes
Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add masking in
passwordcredentials when logging attach information in the logs, similar to the mother duck token.