Skip to content

fix: ensure dbt BigQueryConfig dataset & project are set #5526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
newtonapple merged 1 commit into from
Oct 10, 2025
Merged

fix: ensure dbt BigQueryConfig dataset & project are set #5526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions sqlmesh/dbt/target.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -601,12 +601,17 @@ def validate_fields(cls, data: t.Any) -> t.Any:
if not isinstance(data, dict):
return data

data["schema"] = data.get("schema") or data.get("dataset")
if not data["schema"]:
# dbt treats schema and dataset interchangeably
schema = data.get("schema") or data.get("dataset")
if not schema:
raise ConfigError("Either schema or dataset must be set")
data["database"] = data.get("database") or data.get("project")
if not data["database"]:
data["dataset"] = data["schema"] = schema

# dbt treats database and project interchangeably
database = data.get("database") or data.get("project")
if not database:
raise ConfigError("Either database or project must be set")
data["database"] = data["project"] = database

return data

Expand Down
12 changes: 6 additions & 6 deletions tests/dbt/test_transformation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1192,13 +1192,13 @@ def test_target_jinja(sushi_test_project: Project):
context = DbtContext()
context._target = BigQueryConfig(
name="target",
schema="test",
database="test",
project="project",
dataset="dataset",
schema="test_value",
database="test_project",
)
assert context.render("{{ target.project }}") == "project"
assert context.render("{{ target.dataset }}") == "dataset"
assert context.render("{{ target.project }}") == "test_project"
assert context.render("{{ target.database }}") == "test_project"
assert context.render("{{ target.schema }}") == "test_value"
assert context.render("{{ target.dataset }}") == "test_value"


@pytest.mark.xdist_group("dbt_manifest")
Expand Down