Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request implements support for dbt macro dispatch search order, allowing projects to customize the order in which packages are searched when resolving macros through the adapter.dispatch() function.
- Adds support for the
dispatchconfiguration in dbt_project.yml files - Updates the adapter dispatch logic to respect custom search orders
- Adds comprehensive test fixtures and test cases to verify the functionality
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sqlmesh/dbt/package.py | Adds dispatch field to Package model and loads dispatch config from project YAML |
| sqlmesh/dbt/loader.py | Integrates dispatch configuration into the project loading process |
| sqlmesh/dbt/context.py | Adds dispatch storage and access methods to DbtContext |
| sqlmesh/dbt/adapter.py | Refactors dispatch method to use custom search orders from configuration |
| tests/dbt/test_adapter.py | Adds new test cases to verify dispatch search order functionality |
| Multiple test fixture files | Creates comprehensive test setup with packages, macros, and dispatch configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| if candidates: | ||
| sorted_candidates = sorted(candidates, key=_relevance) | ||
| return candidates[sorted_candidates[0]] | ||
| for prefix in (f"{target_type}__", "default__", ""): |
Contributor
There was a problem hiding this comment.
why is the empty string needed? I might be wrong but also looking at the docs when dbt doesn't find either the adapter or namespace in dispatch it always falls back to default__ as prefix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR: