Merged
Conversation
Collaborator
|
Can you please add a test that exercises this change? |
erindru
reviewed
Sep 23, 2025
sqlmesh/dbt/test.py
Outdated
|
|
||
| audit: Audit | ||
| if self.package_name != context.project_name: | ||
| self.name = f"{self.package_name}.{self.name}" |
Collaborator
There was a problem hiding this comment.
This subtly mutates self.name and makes it different before / after calling to_sqlmesh().
Have you considered using a local variable for this instead and passing it for the name= parameter in the StandaloneAudit/ModelAudit constructors?
toriwei
force-pushed
the
tori/fix-duplicate-audits
branch
from
cb7ff1a to
eb01334
Compare
crericha
approved these changes
Sep 24, 2025
toriwei
force-pushed
the
tori/fix-duplicate-audits
branch
from
d6d3c7c to
e3c713c
Compare
toriwei
force-pushed
the
tori/fix-duplicate-audits
branch
from
d6a4917 to
64d2a37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create unique
canonical_nameto prevent duplicate audit names