Skip to content

Fix: port sqlglot pipe syntax fix in _parse_select #5373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
georgesittas merged 1 commit into from
Sep 15, 2025
Merged

Fix: port sqlglot pipe syntax fix in _parse_select #5373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions sqlmesh/core/dialect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,13 +350,15 @@ def _parse_select(
parse_subquery_alias: bool = True,
parse_set_operation: bool = True,
consume_pipe: bool = True,
from_: t.Optional[exp.From] = None,
) -> t.Optional[exp.Expression]:
select = self.__parse_select( # type: ignore
nested=nested,
table=table,
parse_subquery_alias=parse_subquery_alias,
parse_set_operation=parse_set_operation,
consume_pipe=consume_pipe,
from_=from_,
)

if (
Expand Down
8 changes: 8 additions & 0 deletions tests/core/test_dialect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -722,3 +722,11 @@ def test_sqlglot_extended_correctly(dialect: str) -> None:
def test_connected_identifier():
ast = d.parse_one("""SELECT ("x"at time zone 'utc')::timestamp as x""", "redshift")
assert ast.sql("redshift") == """SELECT CAST(("x" AT TIME ZONE 'utc') AS TIMESTAMP) AS x"""


def test_pipe_syntax():
ast = d.parse_one("SELECT * FROM (FROM t2 |> SELECT id)", "bigquery")
assert (
ast.sql("bigquery")
== "SELECT * FROM (WITH __tmp1 AS (SELECT id FROM t2) SELECT * FROM __tmp1)"
)