Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 26 additions & 20 deletions sqlmesh/dbt/model.py
Original file line number Diff line number Diff line change
Expand Up @@ -510,27 +510,33 @@ def to_sqlmesh(
physical_properties: t.Dict[str, t.Any] = {}

if self.partition_by:
partitioned_by = []
if isinstance(self.partition_by, list):
for p in self.partition_by:
try:
partitioned_by.append(d.parse_one(p, dialect=model_dialect))
except SqlglotError as e:
raise ConfigError(
f"Failed to parse model '{self.canonical_name(context)}' partition_by field '{p}' in '{self.path}': {e}"
) from e
elif isinstance(self.partition_by, dict):
if context.target.dialect == "bigquery":
partitioned_by.append(self._big_query_partition_by_expr(context))
else:
logger.warning(
"Ignoring partition_by config for model '%s' targeting %s. The format of the config field is only supported for BigQuery.",
self.name,
context.target.dialect,
)
if isinstance(kind, ViewKind):
logger.warning(
"Ignoring partition_by config for model '%s'; partition_by is not supported for views.",
self.name,
)
else:
partitioned_by = []
if isinstance(self.partition_by, list):
for p in self.partition_by:
try:
partitioned_by.append(d.parse_one(p, dialect=model_dialect))
except SqlglotError as e:
raise ConfigError(
f"Failed to parse model '{self.canonical_name(context)}' partition_by field '{p}' in '{self.path}': {e}"
) from e
elif isinstance(self.partition_by, dict):
if context.target.dialect == "bigquery":
partitioned_by.append(self._big_query_partition_by_expr(context))
else:
logger.warning(
"Ignoring partition_by config for model '%s' targeting %s. The format of the config field is only supported for BigQuery.",
self.name,
context.target.dialect,
)

if partitioned_by:
optional_kwargs["partitioned_by"] = partitioned_by
if partitioned_by:
optional_kwargs["partitioned_by"] = partitioned_by

if self.cluster_by:
if isinstance(kind, ViewKind):
Expand Down
12 changes: 12 additions & 0 deletions tests/dbt/test_transformation.py
Original file line number Diff line number Diff line change
Expand Up @@ -1683,6 +1683,18 @@ def test_partition_by(sushi_test_project: Project):
context.target = DuckDbConfig(name="target", schema="foo")
assert model_config.to_sqlmesh(context).partitioned_by == []

model_config = ModelConfig(
name="model",
alias="model",
schema="test",
package_name="package",
materialized=Materialization.VIEW.value,
unique_key="ds",
partition_by={"field": "ds", "granularity": "month"},
sql="""SELECT 1 AS one, ds FROM foo""",
)
assert model_config.to_sqlmesh(context).partitioned_by == []


@pytest.mark.xdist_group("dbt_manifest")
def test_partition_by_none(sushi_test_project: Project):
Expand Down