Fix(databricks): Materialized view drop failure due to incorrect type#5351
Merged
themisvaltinos merged 4 commits intomainfrom Sep 11, 2025
Merged
Fix(databricks): Materialized view drop failure due to incorrect type#5351themisvaltinos merged 4 commits intomainfrom
themisvaltinos merged 4 commits intomainfrom
Conversation
themisvaltinos
commented
Sep 11, 2025
eakmanrq
approved these changes
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #5249 and correctly maps
MATERIALIZED_VIEWtomaterialized_viewinstead ofviewin the case statement of_get_data_objects.Previously the Databricks adapter was incorrectly identifying materialized views as regular views. This caused
DROP VIEWto be issued instead ofDROP MATERIALIZED VIEWresulting in the error:Cannot drop a materialized view with DROP VIEW. Please use DROP MATERIALIZED VIEW insteadfailure scenatio
So this wasn't exercised before #5087 but now since
drop_data_object_on_type_mismatchis called like this insidecreate_view:get_data_objectinternally would return a materialised view's type as view while the conditional would correctly map as materialised viewdrop_data_objectoperation insidedrop_data_object_on_type_mismatchviewthus resulting in the error