Fix: normalize unit testing fixture catalog#5343
Merged
georgesittas merged 1 commit intomainfrom Sep 11, 2025
Merged
Conversation
erindru
approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I came across this issue in a project that used a Snowflake test connection, so it's kinda "out of the blue" / no further context to provide.
In unit tests, we create fixture tables of the form
<engine_adapter_catalog>.<randomly_generated_testing_schema>.<fqn>. The PR normalizes the leftmost part, because we omitted doing it and then quoted it in_render_model_query(see howtable_mappingis used in the renderer), so for Snowflake we could end up with errors likeDatabase '"george"' does not exist or the required permissions are missing.I added a simple unit test for Snowflake to ensure there are no regressions in the future.