Skip to content

Chore: warn instead of error if description present for non-existent col #5319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
treysp wants to merge 1 commit into from
Closed

Chore: warn instead of error if description present for non-existent col #5319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion sqlmesh/core/model/meta.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,9 @@ def _column_descriptions_validator(
if columns_to_types:
for column_name in col_descriptions:
if column_name not in columns_to_types:
raise ConfigError(
from sqlmesh.core.console import get_console

get_console().log_warning(
f"In model '{info.data['name']}', a description is provided for column '{column_name}' but it is not a column in the model."
)

Expand Down
7 changes: 5 additions & 2 deletions tests/core/test_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2925,7 +2925,8 @@ def a_model(context):

assert py_model.columns_to_types.keys() == py_model.column_descriptions.keys()

# error: `columns` and `column_descriptions` column names are different cases, quoting preserves case
# warning: `columns` and `column_descriptions` column names are quoted and different cases,
# so column not present in model
@model(
"col_descriptions_quoted",
columns={'"col"': "int"},
Expand All @@ -2934,11 +2935,13 @@ def a_model(context):
def b_model(context):
pass

with pytest.raises(ConfigError, match="a description is provided for column 'COL'"):
with patch.object(get_console(), "log_warning") as mock_logger:
py_model = model.get_registry()["col_descriptions_quoted"].model(
module_path=Path("."),
path=Path("."),
)
assert mock_logger.call_count == 1
assert "a description is provided for column 'COL'" in mock_logger.call_args[0][0]


def test_python_model_unsupported_kind() -> None:
Expand Down