Skip to content

Fix: Allow partials by default for all models converted from a dbt project #5303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
izeigerman merged 2 commits into from
Sep 4, 2025
Merged

Fix: Allow partials by default for all models converted from a dbt project #5303

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b485401
Fix: Allow partials by default for all models converted from a dbt pr…
izeigerman Sep 4, 2025
3f8d674
fix tests
izeigerman Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions sqlmesh/dbt/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ class ModelConfig(BaseModelConfig):
batch_concurrency: t.Optional[int] = None
forward_only: bool = True
disable_restatement: t.Optional[bool] = None
allow_partials: t.Optional[bool] = None
allow_partials: bool = True
physical_version: t.Optional[str] = None
auto_restatement_cron: t.Optional[str] = None
auto_restatement_intervals: t.Optional[int] = None
Expand Down Expand Up @@ -620,11 +620,7 @@ def to_sqlmesh(
model_kwargs["physical_properties"] = physical_properties

allow_partials = model_kwargs.pop("allow_partials", None)
if (
allow_partials is None
and kind.is_materialized
and not kind.is_incremental_by_time_range
):
if allow_partials is None:
# Set allow_partials to True for dbt models to preserve the original semantics.
allow_partials = True

Expand Down
1 change: 1 addition & 0 deletions tests/dbt/test_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@ def test_model_to_sqlmesh_fields(dbt_dummy_postgres_config: PostgresConfig):
assert model.dialect == "postgres"
assert model.owner == "Sally"
assert model.tags == ["test", "incremental"]
assert model.allow_partials
kind = t.cast(IncrementalByUniqueKeyKind, model.kind)
assert kind.batch_size == 5
assert kind.lookback == 3
Expand Down